-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for FireEye HX .mans files #1205
Conversation
add support for mans files using mans_to_es library Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>
@googlebot I fixed it. |
Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>
Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>
Co-Authored-By: Arcuri Davide <dadokkio@gmail.com>
@googlebot I fixed it. |
Hm something is still wrong with the CLA form. @dadokkio is the mentioned gmail alias: dadokkio@gmail.com linked to your github account? Maybe it is easier if @garanews changes the co-author to the github account name, not the email alias? |
Hello @jaegeral , I just changed in comment, should I do anything else? |
I've just signed the cla with both my google accounts, so now it should be ok. |
@googlebot I fixed it. |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
1 similar comment
@googlebot I consent. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only a very minor comment here, otherwise looks good
and you'll need to update your branch, since it is out-of-date with the base branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one qq
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... and sorry for the long time it took to get the review done.
add support for mans files using mans_to_es library
Co-Authored-By: @dadokkio